<html>
<head><meta charset="utf-8"><title>expr-use-visitor refactoring · t-compiler/wg-rfc-2229 · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/index.html">t-compiler/wg-rfc-2229</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor.20refactoring.html">expr-use-visitor refactoring</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="164177221"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor%20refactoring/near/164177221" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor.20refactoring.html#164177221">(Apr 25 2019 at 14:52)</a>:</h4>
<p>So in the meeting today, <span class="user-mention" data-user-id="124288">@oli</span> mentioned that clippy makes a lot of use of the <code>ExprUseVisitor</code>. We should probably take a look at those uses, as I am contemplating proposing a rewrite as part of this WG, and if so we would want to make sure those uses are accommodated.</p>



<a name="164177300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor%20refactoring/near/164177300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor.20refactoring.html#164177300">(Apr 25 2019 at 14:53)</a>:</h4>
<p><span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="164177463"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor%20refactoring/near/164177463" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor.20refactoring.html#164177463">(Apr 25 2019 at 14:54)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  any code you have in mind that we can look at to get an idea ?</p>



<a name="164177531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor%20refactoring/near/164177531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor.20refactoring.html#164177531">(Apr 25 2019 at 14:55)</a>:</h4>
<p>Well, these are our use sites: <a href="https://github.com/rust-lang/rust-clippy/search?q=ExprUseVisitor&amp;unscoped_q=ExprUseVisitor" target="_blank" title="https://github.com/rust-lang/rust-clippy/search?q=ExprUseVisitor&amp;unscoped_q=ExprUseVisitor">https://github.com/rust-lang/rust-clippy/search?q=ExprUseVisitor&amp;unscoped_q=ExprUseVisitor</a></p>



<a name="164180408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor%20refactoring/near/164180408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor.20refactoring.html#164180408">(Apr 25 2019 at 15:26)</a>:</h4>
<p>I'm certain some of these could be written differently (e.g. as a MIR-lint), so if that's preferrable, I'd be happy to rewrite some of these</p>



<a name="164180486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor%20refactoring/near/164180486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/expr-use-visitor.20refactoring.html#164180486">(Apr 25 2019 at 15:27)</a>:</h4>
<p>Thanks for the links <span class="user-mention" data-user-id="124288">@oli</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>